search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Add ActivateBluetoothActivity to activate bluetooth before users go to the Connection page #157

Closed clenrock closed 7 years ago

clenrock commented 7 years ago

What

This Pull Request adds a new activity which will prompt the user to activate Bluetooth before they go to the actual connections page.

Why

Before, if the user didn't have their Bluetooth on when they went to the connections page, it would try to load paired devices and discovered devices, but Bluetooth first have to be put on. But when it's on, you have to reload the page by going back and going to the page again. This makes it more user-friendly and also adds the message that we won't do anything with your location.

How

This feature can be viewed/tested within the project by opening the app (on a real phone) and pressing the Bluetooth icon in the main activity.

Alternative implementation

Other implementations that I've have considered are prompting the user to activate Bluetooth before going to the Connection scene. But this looked like the app was crashing.

Notes

Note that I didn't create any tests yet, and that this doesn't close issue #143. The tests and the rest of the user-friendliness will be created when #141 is merged, that PR fixes some Bluetooth issues.

TheBonheurs commented 7 years ago

Oh yeah one more thing, don't forget the tests, unless you are @jverbraeken and do them in a separate pr ofcourse 😄

clenrock commented 7 years ago

@TheBonheurs I on purpose didn't create any tests yet, which I also explained in the PR notes. I wanted to wait before the issue #141 was included. It is now, so I can create a test!