Closed jverbraeken closed 7 years ago
@ericcornelissen
I like the addition! However, with this change once I logged in I can not logout (except when I stop the process). I think it is better if you can return to the
LoginActivity
with the back button 😄
I'm not sure if we actually want to use the Loginscreen as you say. Actually, it's not a loginscreen because you don't login but just fill in a password to verify your identity. When you've verified your identity, I don't think that anyone would ever want to go back to that "verify identity" screen to type again his password.
I'm not sure if we actually want to use the Loginscreen as you say. Actually, it's not a loginscreen because you don't login but just fill in a password to verify your identity. When you've verified your identity, I don't think that anyone would ever want to go back to that "verify identity" screen to type again his password.
I don't really agree... You can go 2 ways with having to login to the app:
However this second approach is not for us as it would kinda require a central server, otherwise the login screen is completely useless. With your (i.e. the current) approach I would even say logging in is only a nuisance as it may be confusing to sometimes having to login and sometimes not having to.
I personally would go for the banking approach of logging in...
@jverbraeken Thanks for listening to my suggestion ❤️
Unfortunately it doesn't seem to be working properly... See the .gif
below:
@ericcornelissen @TheBonheurs Implemented your suggestions!
@ericcornelissen Fixed!
Relevant Issues: -
Related Pull Requests: -
What
This Pull Request adds to the repository
Why
This Pull Request is needed because you went back to the previous activity (possibly the entryactivity) in the old version.
How
This feature can be viewed/tested within the project by using the back button in login / main activity
Alternative implementation
Other implementations that I've have considered are
Notes