ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Refactor Bluetooth #170

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This Pull Request adds to the repository a full refractoring of the Bluetooth related classes.

Why

This Pull Request is needed because the old Bluetooth class was difficult to understand, the Bluetooth screen had to be opened to receive contacts and only contacts could be sent and PMD didn't like the coupling / class size

How

This feature can be viewed/tested within the project by sharing contacts over Bluetooth

Alternative implementation

Other implementations that I've have considered are -

Notes

The very first meeting I'll give you a walkthrough through this new code ;-)

jverbraeken commented 7 years ago

@ericcornelissen @KilianCallebaut @clenrock Implemented all your suggestions! Great to get so much feedback :P