ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Configure the modules directory correctly in BetterCodeHub #179

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This Pull Request adds to the repository the correct configuration of our modules in BetterCodeHub

Why

This Pull Request is needed because BetterCodeHub considered our "app" modules as our only module while it should regard activites, data_objects, modules, etc. as our modules.

How

This feature can be viewed/tested within the project by checking BetterCodeHub and verifying that it uses the correct modules

Alternative implementation

Other implementations that I've have considered are -

Notes

BetterCodeHub will complain that we lost a guideline and this is indeed true. We lost "Couple Architecture Components Loosely" but won "Keep Architecture Components Balanced" (by instrumenting BetterCodeHub to analyze our repo correctly). However, according to the instructors at the SIG lecture we can safely ignore that warning because the way we structured our app is excellent according to them. They told us that it's just a general metric and that we should interpret it in our case as irrelevant.