ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Remove duplicate code #186

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This Pull Request adds to the repository the removal of duplicate code. setupBluetoothAdapter was already used in ActivateBluetoothActivity and thus is not needed anymore BluetoothConnectionActivity. Also, I fixed a potential bug in which connectThread was not cancelled.

Why

This Pull Request is needed because we don't want bugs and we don't want duplicate code

How

This feature can be viewed/tested within the project by static code analysis

Alternative implementation

Other implementations that I've have considered are

Notes