search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Added extra classes to include in the data wrapper#189 #190

Closed TheBonheurs closed 7 years ago

TheBonheurs commented 7 years ago

What

This Pull Request adds to the repository Two extra classes that encapsylate collections of other classes.

Why

This Pull Request is needed because We use a DataWrapper when we are sending data over bluetooth/nfc/qr and it encapsulates an object but won't work with a List. These new classes will save those lists within them.

How

This feature can be viewed/tested within the project by Adding code to send multuple contacts or taps and seeing if they are parsed correctly.

Alternative implementation

Other implementations that I've have considered are Using an arraylist (or any other list) as a param for DataWrapper but it proved to be cumbersome and produced nasty code...

Notes

Not really

TheBonheurs commented 7 years ago

Sure! I was looking at the Contact tests as reference and it was missing there though 😨

jverbraeken commented 7 years ago

Sure! I was looking at the Contact tests as reference and it was missing there though 😨

Oops, fixed that in #185