Closed jverbraeken closed 7 years ago
I started on something related to this on order-strings 😄 Are you OK if I merge that branch in this PR?
@ericcornelissen
I started on something related to this on order-strings 😄 Are you OK if I merge that branch in this PR?
No problem 👍 However, I fixed all warnings/errors that could be fixed already, so I'm not sure whether it's worth the time to merge them...
As the title of the branch ("order strings") suggests, its not aimed at fixing any actual errors, it is just ordering the strings defined in ../values/strings.xml
and ../values-nl/strings.xml
to make them easier to read for humans 😄
Relevant Issues: -
Related Pull Requests: -
What
This Pull Request adds to the repository fixes more many Android Lint warnings/errors
Why
This Pull Request is needed because there were quite some warnings/errors and most of these were relevant and indicated small code flaws in our code
How
This feature can be viewed/tested within the project by running Android Lint
Alternative implementation
Other implementations that I've have considered are
Notes
The only two warnings that I didn't fix were a warning that Eric's visual verification image is not available in mdpi, xhdpi and xxhdpi and that labelFor was missing for a file, but both are not easy to fix and are just a small warning (2/10)