ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Enable auto backup google#63 #199

Closed TheBonheurs closed 7 years ago

TheBonheurs commented 7 years ago

What

Auto backup feature for apps provided by google

Why

This Pull Request is needed because now we can assure the users their data will be backed up.

How

This feature can be viewed/tested within the project by :

Alternative implementation

Other implementations that I've have considered are casting our contacts to google contacts and using that specific google contact backup feature but according to @jverbraeken it was too complicated.

Notes

ericcornelissen commented 7 years ago

I have one important question about this feature, is it enabled by default?

I don't think our users, who are particularly nervous about their privacy, want to have this feature enabled by default... I would be okay with a checkbox in the first time use activity asking users if they want to use this feature.

TheBonheurs commented 7 years ago

As to your question yes if you have Google backup enabled on your mobile device this will happen automatically. But I think if the users find this sketchy they will have that option disabled on their device. This will mean that their data won't be backed up though bu as I said in the alternatives I haven't found an elegant way to perform this backup manually.

ericcornelissen commented 7 years ago

OK, just to be clear: If I don't have Google Backup enabled, then this feature won't do anything?

If that is the case I'll approve this PR 😄

TheBonheurs commented 7 years ago

knipsel

ericcornelissen commented 7 years ago

@TheBonheurs, why did you close this PR?

TheBonheurs commented 7 years ago

No idea tbh @ericcornelissen , can't remember it either

TheBonheurs commented 7 years ago

It could be that I moved this item on the waffle queue to done or something like that but it shouldn't immediately close this right?

ericcornelissen commented 7 years ago

I think it might, it seems like a plausible explanation 😆

ericcornelissen commented 7 years ago

Reopening this, so we can reconsider merging it 😄