ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Let the build fail on Android Lint errors #210

Closed ericcornelissen closed 7 years ago

ericcornelissen commented 7 years ago

What

This Pull Request removes some newly introduced Android Lint errors and attempts to let the build fail when there is an Android Lint error.

Why

This Pull Request is needed because we want to improve our code, and Android Lint is an important tool that can help us with that.

How

Try to introduce an error (that would be reported by Android Lint) and build the project, the build should fail.

Alternative implementation

None

Notes

Be sure to try the How as I'm not 100% sure this PR will properly enable Android Lint.

I would like to request anyone to help me gather all icons in the mdpi, hdpi, xhdpi and xxhdpi densities (details here). Feel free to send me copies of the files in the different sizes or the original files (e.g. photoshop/vector image) of the image or push on this branch yourself. Icons overview: [REMOVED]