ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Small improvements to first time use of the app #213

Closed ericcornelissen closed 7 years ago

ericcornelissen commented 7 years ago

What

Changes in this PR:

Why

Mainly to improve the design of the WelcomeActivity and CreateProfileActivity activities. But while I was working on it I couldn't help but update some of the related code 😄

How

Uninstall the app and install it again, just check out the activities and tell me what you think 🙂

Alternative implementation

None

Notes

Opening the app and seeing the design is most important when reviewing this PR. Not the actual code changes, these are generally very simple refactors (like renaming things).

clenrock commented 7 years ago

image Could you make this logo a bit larger? Not sure if this is changed in this PR or the lint PR where we added all the new dimensions

ericcornelissen commented 7 years ago

@clenrock I see what you mean but I'm unable to solve it and if you look at the diff of this PR you can see that it was not introduced in this PR 😅 Feel free to play around on this branch and push a solution if you find one... Otherwise maybe open an issue for the problem.