search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Add hardware acceleration #217

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This Pull Request adds to the repository hardware acceleration for the application

Why

This Pull Request is needed because it's good practice to use hardware acceleration when it's available because it's a lot faster

How

This feature can be viewed/tested within the project by running the app and verifying that everything still works

Alternative implementation

Other implementations that I've have considered are -

Notes

I couldn't test if the app still works myself, so it's important that you check if before you approve this PR.

TheBonheurs commented 7 years ago

This Pull Request is needed because it's good practice to use hardware acceleration when it's available because it's a lot faster

Do you have a source on this?

ericcornelissen commented 7 years ago

From stackoverflow (link):

It is advised to use hardware acceleration only if you have complex custom computations for scaling, rotating and translating of images, but do not use it for drawing lines or curves (and other trivial operations) (source)

So I guess we don't need it 🙂

jverbraeken commented 7 years ago

@ericcornelissen I agree with you