search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Make it possible to click on the label, fixes the bug #216 #219

Closed clenrock closed 7 years ago

clenrock commented 7 years ago

What

This Pull Request adds to the repository a fix for the bug described at #216.

How

This feature can be viewed/tested within the project by opening the MainActivity and clicking on the fab button's label.

Notes

Unfortunately I had to make the switch-case an if-else statement

ericcornelissen commented 7 years ago

Have you considered looking at the labelFor property of the Label in order to get the ID of the actual button?

clenrock commented 7 years ago

@ericcornelissen No, do you think that makes a nicer solution?

ericcornelissen commented 7 years ago

If it works it would because you could keep the switch-statement

clenrock commented 7 years ago

@ericcornelissen I tried it, but the ID that is returned is not the one of the button. So I'll keep it like this

ericcornelissen commented 7 years ago

Too bad 😢