ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Fix all design errors + making QR extra neat #224

Closed clenrock closed 7 years ago

clenrock commented 7 years ago

What

This Pull Request fixes all the design errors which can be seen at the front-end of our app.

Why

This Pull Request is needed because having a perfect design makes the app look much more professional.

How

This feature can be viewed/tested within the project by opening the app and clicking through it and checking if something LOOKS weird. Also note the new QR activity ordering.

Notes

@ericcornelissen Sorry for changing the icon dimensions agian, but some icons were 2x too large.

ericcornelissen commented 7 years ago

Sorry for changing the icon dimensions agian, but some icons were 2x too large.

No problem, if Android Lint doesn't complain, I don't complain 😄

clenrock commented 7 years ago

@TheBonheurs Sure, but these were all very small errors in the design which takes more time to document than to fix

ericcornelissen commented 7 years ago

@clenrock still, it may be obvious to you because you made the changes, but not everyone notices everything you changed 😉