search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Remove demo database contents from the app, closes #226 #230

Closed ericcornelissen closed 7 years ago

ericcornelissen commented 7 years ago

What

This Pull Request removes from the repository the demo database content loaded in the MainActivity. Besides that it also adds an androidTest for clicking on a contact in the MainActivity.

Why

This Pull Request is needed because the demo database content is no longer needed or useful, since we can now exchange contacts.

How

This feature can be viewed/tested within the project by opening the app and looking at the contacts list in the MainActivity. Beware that it may contact contacts inserted during androidTests!

Alternative implementation

n/a

Notes

None

ericcornelissen commented 7 years ago

@clenrock you can always temporarily add code to add a contact to the database. But I think we've come to a stage of development where this should no longer be part of the production code (i.e. code on the develop or master branch)

clenrock commented 7 years ago

@ericcornelissen I don't agree, because 'temporarily adding new code' takes more time if you want to test it, and for now it doesn't matter that the code is still there

ericcornelissen commented 7 years ago

Well I'm not sure how much of a problem that is, since after adding a contact once it should stay in the database until uninstall the app. Also:

...temporarily adding new code takes more time if you want to test it...

I don't thinks this is that big of a deal. Besides the fact that you should only have to do it once (see above), adding a contact to the database shouldn't take any longer then a minute..