search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Make it possible to exchange contacts via nfc, not yet fully manually tested #8 #231

Closed TheBonheurs closed 7 years ago

TheBonheurs commented 7 years ago

What

This pr adds a new activity which should be able to exchange contacts over nfc (Android Beam)

Why

This Pull Request is needed because NFC is MITM-proof and requires less hassle to setup.

How

This feature can be viewed/tested within the project by clicking the pairing menu in the main activity and selecting NFC. This should lead to the NFCActivity which should open up the activity with an instruction gif of what to do.

Alternative implementation

Other implementations that I've have considered are making it so that our nfc handler fully replaces the android nfc adapter but that proved difficult.

Notes

Yes, as it's stated in the title this functionality needs to be tested with actual phones, the activity (design wise) can still be improved and there are even some activity transitions missing but it will be add to this pr before merging.

TheBonheurs commented 7 years ago

Should've fixed all the remarks @jverbraeken @ericcornelissen , tell me if I missed something