search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Encode the visual pattern, closes #233 #250

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This Pull Request adds to the repository an encoding for the pattern tapped in VisualVerificationActivity. Each button has a value between 1 and 12. Initially code = 0 Every tap: code = code x 12 + value

Why

This Pull Request is needed because we need to encode the pattern tapped by the user to encrypt the data send over Bluetooth

How

This feature can be viewed/tested within the project by... This is only possible after the whole feature is implemented

Alternative implementation

None considered

Notes

This PR does not encrypt/decrypt the data. #227 contains a custom send method and a local branch of @kcallebaut contains method to encrypt/decrypt the data. We'll have to wait for those to be merged before we can complete the whole feature

jverbraeken commented 7 years ago

@TheBonheurs This PR doesn't necessarily make encrypting easier, but provides a way to get a certain unique code that always corresponds to the images that were tapped. This PR is not meant as a huge PR with a thousand lines of code that contains a fully fledged encryption protocol for VisualVerification, but is a small part of the total feature