ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Verify name does not contain newline #251

Open jverbraeken opened 7 years ago

jverbraeken commented 7 years ago

User story

As a developer I don't want the user to use a semicolon in his name so that I can use the semicolon as a logical separator when sending data.

What

This issue demands to verify the user input as name so that it does not a semicolon

Why

This issue is needed for the project because the QR code is read incorrectly if the name contains a semicolon

How

This feature can be added by verifying the user input in the create-user activity

Definition of ready

This features is not ready until the following issues are finished:

Definition of done

This task can be considered done when

Notes

ericcornelissen commented 7 years ago

As discussed in #245 (discussion on the 5th comment in the first review by @jverbraeken), maybe change this to "Verify name does not contain new lines"

ericcornelissen commented 7 years ago

@jverbraeken, why did you close this issue?

jverbraeken commented 7 years ago

@ericcornelissen This issue is closed because #256 makes it not possible to type symbols other than characters and numbers, eliminating the need for this issue

ericcornelissen commented 7 years ago

Reopening this as #256 won't fix this problem 🙂