ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Encrypt the database, closes #202 and closes #44 #252

Closed KilianCallebaut closed 7 years ago

KilianCallebaut commented 7 years ago

What

Added functionality for checking passwords, encrypting strings using various methods and storing the database encrypted.

Why

This Pull Request is needed because it adds more security to the user's profile and data.

How

This feature can be viewed/tested within the project by checking if the database is stored encrypted after each operation. Also, one could see if they can log in using their created password and no other.

Alternative implementation

Other implementations that I've have considered are

Notes

There are a lot of tests missing, since there kept popping up problems and other collaborators needed parts of the system. These will be added later. Also in the encrypted saver there are methods commented out. This is because of circumstances made it so that these were no longer necessairy encryption methods, yet since they are working implementations other people could perhaps use them.

jverbraeken commented 7 years ago

Can you make several smaller PR's instead of a single very large one next time? :P

ericcornelissen commented 7 years ago

Merged regardless of Travis CI status, the build time exceeded time limit (50 min) multiple times