search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Move DatabaseException to the database package #283

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This Pull Request moves DatabaseException from exceptions to modules.database

Why

This Pull Request is needed because we don't want to put interfaces in a package named interfaces, to put abstract class in a package named abstract classes and we also don't want to put all exceptions in a package called exceptions. We want to group things that are related to each other by functionality, because they depend on each other, in the same package. Only exceptions that are really generic can be justified to be in such a generic package like exceptions and DatabaseException certainly does not belong to the category.

How

This feature can be viewed/tested within the project by

Alternative implementation

Other implementations that I've have considered are

Notes

ericcornelissen commented 7 years ago

Merged regardless of Travis CI status, Findbugs workers kept crashing 😕