search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Remove CircularList & RhythmHelper #285

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This Pull Request removes CircularList

Why

This Pull Request is needed because CircularList is unused. It was added so that the user could continously tap a rhythm till he tapped the correct rhythm, but we later agreed to use a different way of pairing by rhythm

How

This feature can be viewed/tested within the project by

Alternative implementation

Other implementations that I've have considered are

Notes

ericcornelissen commented 7 years ago

Are you sure you want to remove this class, it is still being used in RhythmHelper.java. It seems this PR should be combined with #284 🤔

ericcornelissen commented 7 years ago

Merged regardless of Travis CI status, kept failing on androidTests most likely due to a the emulator having crashed 😕