search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Increase the number of required blocks in the visual verification method #287

Closed ericcornelissen closed 7 years ago

ericcornelissen commented 7 years ago

What

This Pull Request updates the repository so it is required to select 6 (instead of 5) tabs in the VisualVerificationActivity.

Why

This Pull Request is needed because it increases the possible entropy of the verification methods, making it more secure. The entropy is increased from 12^5 = 248.832 to 12^6 = 2.985.984

How

This feature can be viewed/tested within the project by opening the app, start a Bluetooth connection and select the Visual verification method, you'll see that you have to select 6 blocks before continuing.

Alternative implementation

n/a

Notes

None

ericcornelissen commented 7 years ago

Merged regardless of Travis CI status, kept failing due to emulator not being able to start