This Pull Request updates the repository so the ContactReceivedHelper is used mainly in the MainActivity and not throughout the Bluetooth activity and separately in the NFCActivity. Besides that it also adds a popup for when the contact is new and added to the database.
Also updated the documentation of the ContactReceivedHelper.
Why
This Pull Request is needed because it improves consistency throughout the app.
How
This feature can be viewed/tested within the project by exchanging contacts through Bluetooth of NFC and seeing that the popups work correctly.
Be careful with QR, even though the code has been changed, QR itself doesn't work correctly (it doesn't actually exchange contacts atm), wait or #245 before this works. QR should also work, but it doesn't lead back to the MainActivity, this is because you want to allow the other to scan your QR as well (the popup shows up in the QRKeyExchangeActivity`).
Relevant Issues: #269
Related Pull Requests: -
What
This Pull Request updates the repository so the
ContactReceivedHelper
is used mainly in theMainActivity
and not throughout the Bluetooth activity and separately in theNFCActivity
. Besides that it also adds a popup for when the contact is new and added to the database.Also updated the documentation of the
ContactReceivedHelper
.Why
This Pull Request is needed because it improves consistency throughout the app.
How
This feature can be viewed/tested within the project by exchanging contacts through Bluetooth of NFC and seeing that the popups work correctly.
Be careful with QR, even though the code has been changed, QR itself doesn't work correctly (it doesn't actually exchange contacts atm), wait or #245 before this works.QR should also work, but it doesn't lead back to theMainActivity
, this is because you want to allow the other to scan your QR as well (the popup shows up in the QRKeyExchangeActivity`).Alternative implementation
None considered
Notes
None