ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Refactor the serialization code #302

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This Pull Request adds to the repository a more thorough testing of the serialization of the exceptions and removes the serialization functionality of modules.

Why

This Pull Request is needed because the serialization was only tested with an exception and not with a message for the exceptions and because you don't want to provide serialization mechanisms for modules when they're not needed (because they are incoherently unsafe and provide hidden, error-prone constructors).

How

This feature can be viewed/tested within the project by running all tests and verifying that everything still works.

Alternative implementation

Other implementations that I've have considered are ...

Notes

None