Closed clenrock closed 7 years ago
Just a quick first comment: I still feel like we need to go with a different name then "Accounts", as discussed in #50
@ericcornelissen I agree, but are we going to change that now, or the next sprint? (where we will discuss this in person)
I agree, but are we going to change that now, or the next sprint? (where we will discuss this in person)
I'm not going to accept this PR before we figured it out, I personally don't care too much whether that is this or next sprint 😉
@ericcornelissen What do you suggest as a fix?
@ericornelissen What do you suggest as a fix?
I've stated my opinion in issue #50. I personally prefer the term "Profile" but I'm open to other suggestions 🙂
@ericcornelissen I don't see much difference in the name Account or Profile, I think they mean the same thing.
Relevant Issues: #27
Related Pull Requests: #57
What
It adds operations to add, delete, update and retrieve the accounts list from the database.
Why
We need a part of the database which saves account information.
How
To test this, it's possible to run the DatabaseTest.
Notes
IMPORTANT: this branch merged the branch for pull request #57 in. So that PR needs to be merged first, before this one can be merged. Also, the database now uses an array of Accounts, so that in the future we can have multiple accounts/profiles/keys :wink: