search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Database modification to fix Read Only error #86

Closed clenrock closed 7 years ago

clenrock commented 7 years ago

Related issue: #84

What

It is a modification in the GsonDatabase and the Constants to fix an Read Only error we've been getting.

Why

With the current database we can't write to files in the app itself, we are trying to write too root now.

How

You can try to print out the database itself and have no problems, where before you got an IOException.

Notes

The code as it is right now is probably not the nicest way to fix the problem. Maybe you think that having a non-static 'constant' in Constants is wrong, which is of course a bit weird. But in the current form with the private variables it doesn't really matter if they are static or not... I'm open to suggestions, and would love to receive so as I already see that it is not a nice solution.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.6%) to 51.263% when pulling 93dff901b04f948fad6b8c23c4fcb5d132db2987 on app/database_fix into d307bc99d40ddd3858115e578953f9d2b2057a33 on develop.