Improve database testing, up to 100%

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.

GNU Lesser General Public License v3.0

2 stars 4 forks source link

Improve database testing, up to 100% #94

Closed ericcornelissen closed 7 years ago

ericcornelissen commented 7 years ago

Relevant Issues: -
Related Pull Requests: -
- *

What

Updated the database test to catch more bugs and get up to 100% coverage in the database package. Also fixed an issue with the RSAKey fromJSON method that didn't work correctly.

Why

More coverage is always better, I personally felt we we're missing a few useful test cases for the database so I added them.

How

Run the tests locally to verify they work.

Alternative implementation

n/a

Notes

n/a

ericcornelissen commented 7 years ago

I will resolve the merge conflicts on this PR as soon as #93 (simple PR that has already been reviewed and approved) and #96 (important fix) are merged into develop 🙂