search

ericcornelissen / pinned-tabs-for-atom

A package for the Atom text editor that allows you to pin tabs
https://atom.io/packages/pinned-tabs
MIT License
18 stars 3 forks source link

No modification icon #51

Closed andrade closed 5 years ago

andrade commented 5 years ago

I have the file-icons package installed with the option Show icons in file tabs disabled.

This appears to cause pinned-tabs (2.1.0 in Linux) to show no icon whatsoever in the pinned tabs. This wouldn't normally be a problem for me. However, it also doesn't inform the user when the tab has been modified.

In the following two images the first pinned tab has been modified. In the first image there is no indication that the file has been modified. In the second image I enabled VS style pinning with width 32 as a hack to receive modification feedback.

screenshot from 2018-12-05 13-17-04

screenshot from 2018-12-05 13-17-23

Ideally, we'd always get the blue circle informing us the file changed even with VS style pinning disabled.

This is related to Issue #32 but I'm not sure it is the same problem.

ericcornelissen commented 5 years ago

It seems this bug was caused by the fact that the .icon class on tabs stays present even if you disable the Show icons in file tabs option (not sure if this was caused by file-icons or by Atom itself 🤔). The bug should be fixed with v2.1.1, but there might be some file types for which the fix does not work.

Please update to the latest version and reopen if the issue persists 🙂