To support non-UTF8 encoding in paths, the name field changed from String
to OsString in the TrashItem struct. As it's a return value, one won't see
code break unless name is actually used.
Bug Fixes
Support non-Unicode paths
There are several spots where paths are assumed to be Unicode. However,
some (all?) operating systems support non-Unicode paths which causes
trash-rs to panic if encountered. I switched some of those code to use
OsStrings instead of Strings. Unfortunately, I had to add a new
dependency, urlencoding, in order to properly handle decoding non-UTF8
byte slices.
As of this commit, the test suite passes and code should be ready, but I
will try to remove the url crate and use urlencoding in its place
in the next commit.
Other
Use objc2-foundation
Bug Fixes (BREAKING)
Support non-UTF8 paths.
Note that this changes the type of returned paths to OsString from String,
hence the breaking change.
Commit Statistics
10 commits contributed to the release over the course of 34 calendar days.
To support non-UTF8 encoding in paths, the name field changed from String
to OsString in the TrashItem struct. As it's a return value, one won't see
code break unless name is actually used.
Bug Fixes
Support non-Unicode paths
There are several spots where paths are assumed to be Unicode. However,
some (all?) operating systems support non-Unicode paths which causes
trash-rs to panic if encountered. I switched some of those code to use
OsStrings instead of Strings. Unfortunately, I had to add a new
dependency, urlencoding, in order to properly handle decoding non-UTF8
byte slices.
As of this commit, the test suite passes and code should be ready, but I
will try to remove the url crate and use urlencoding in its place
in the next commit.
Other
Use objc2-foundation
Bug Fixes (BREAKING)
Support non-UTF8 paths.
Note that this changes the type of returned paths to OsString from String,
hence the breaking change.
Commit Statistics
10 commits contributed to the release over the course of 34 calendar days.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps trash from 4.1.1 to 5.0.0.
Release notes
Sourced from trash's releases.
... (truncated)
Changelog
Sourced from trash's changelog.
... (truncated)
Commits
a754f4a
Release trash v5.0.002d1a8d
prepare changelog prior to release0971b8f
fix!: Support non-UTF8 paths.e4b7119
Update Windows code to account for API change559b57b
Simplify Linux/BSD only tests for non-UTF8 paths209db9d
Impl test for listing invalid UTF8 trash items2f31116
Cleanup non-Unicode support for readability67fb256
Removeurl
and replace withurlencoding
15a15f8
fix: Support non-Unicode paths46585ce
Merge pull request #107 from madsmtm/objc2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show