ericdanan / counsel-projectile

Ivy UI for Projectile
286 stars 39 forks source link

counsel-projectile-grep not prompting for additional options #165

Closed fixmaker closed 3 years ago

fixmaker commented 4 years ago

According to the documentation for counsel-projectile-grep:

OPTIONS-OR-CMD, if non-nil, is a string containing either additional options to be passed to grep, or an alternative git grep command. It is read from the minibuffer if the function is called with a prefix argument.

However when I run C-u M-x counsel-projectile-grep it does not prompt for any options in the minibuffer (the search prompt is shown immediately, regardless of whether the command is run with a prefix argument).

ashton314 commented 4 years ago

Seems to be happening with counsel-projectile-rg as well

ericdanan commented 3 years ago

Thanks. The issue was affecting counsel-projectile-grep/git-grep/ag-rg for various reasons. It should now hopefully all be working, both when calling these commands from a project buffer and when switching project. Please test.

fixmaker commented 3 years ago

Thanks for maintaining a great package.

This seems to be working now when called from within a project buffer, but when called from outside of a project buffer then (as expected) the minibuffer will prompt for the name of the project to use, but there is no prompt for any grep options.

ericdanan commented 3 years ago

When you select the project, you need to C-u RET as the prefix you initially passed to counsel-projectile-rg is gone at that point.