ericdegroot / gr-dsss

116 stars 12 forks source link

DSSS decoder is not functional #3

Closed kantooon closed 5 years ago

kantooon commented 5 years ago

The original code of the despreader was completely non-functional because the internal samples per symbol value was never set. #2 pull request fixes this issue, removes existing example and adds a more relevant BPSK DSSS example.

ericdegroot commented 5 years ago

Hi Adrian,

Thank you for taking to the time to make a pull request. I wrote that code for a grad school class a bunch of years ago. I don't know that I'm really in a position to evaluate your changes any more. I haven't used GNU Radio in a long time. We use different DSP software within the industry I ended up in.

May I suggest forking the project with these changes applied and making it available under your own name? I would be happy to place a note at the top of my README for folks to check yours out.

Thanks,

Eric

On 2019-08-07 05:36, adrian wrote:

The original code of the despreader was completely non-functional because the internal samples per symbol value was never set. #2 [1] pull request fixes this issue, removes existing example and adds a more relevant BPSK DSSS example.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub [2], or mute the thread [3].

Links:

[1] https://github.com/ericdegroot/gr-dsss/pull/2 [2] https://github.com/ericdegroot/gr-dsss/issues/3?email_source=notifications&email_token=AAIF43EO5QSPQGNLXI4RNVDQDK6TTA5CNFSM4IJ744SKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HD4GUSQ [3] https://github.com/notifications/unsubscribe-auth/AAIF43CI3R6WOBIPAXX7EGDQDK6TTANCNFSM4IJ744SA

kantooon commented 5 years ago

Thanks, I already created a fork with the changes, just posting this ticket in case you wanted to merge the fixes upstream.

kantooon commented 5 years ago

This issue along with the high CPU usage is fixed in #4