search

ericdrowell / KineticJS

KineticJS is an HTML5 Canvas JavaScript framework that extends the 2d context by enabling canvas interactivity for desktop and mobile applications.
http://www.kineticjs.com
3.98k stars 753 forks source link

Kinetic.Text RTLing #858

Open hillai opened 10 years ago

hillai commented 10 years ago

Hi!

First of all I must say you've done a very good job with KineticJS. But as I'm working on a project that envolves text in Hebrew, I noticed that the Kinetic.Text element does not support right-to-left writing. I tried RTLing my text manually (AKA moving punctuation to the left) but it's very far from being perfect - when you write a sentence that containes Hebrew and English letters, for example, the output looks terrible. So my request is, can you please add a "dir" attribute for Kinetic.Text, allowing us Hebrew and Arabic developers to write right-to-left text? Please? Pretty please?

Thanks a lot, Hillai

Vintage-2212 commented 10 years ago

I am also an Israeli using your KineticJS work, and as hillai said, it's fantastic, but I also noticed the missing attribute, and I agree that it would be very helpful to have it. Thanks you very much

vmichnowicz commented 10 years ago

Does this work?

<canvas dir="rtl">
hillai commented 10 years ago

Not with KineticJS it doesn't.