ericdunipace / RcppCGAL

Package to link to CGAL (Computational Geometry Algorithms Library) header files. Downloads CGAL version 5.6.1 on install.
10 stars 3 forks source link

Error .cgal_url (Github action) #10

Closed stla closed 1 year ago

stla commented 1 year ago

Hello Eric,

Previously I had nothing to do, but now when I use a Github action for one of my packages using RcppCGAL, the header files are not automatically downloaded. So I added RcppCGAL::cgal_install() to the YAML file defining the Github action, but then this generates an error:

Error in assets[[which.as]] : 
  attempt to select less than one element in get1index
Calls: <Anonymous> -> .cgal_url

Would you have an idea about what happens?

stla commented 1 year ago

Now I've tried library(RcppCGAL); cgal_install('https://github.com/CGAL/cgal/releases', '5.5.2') but then I get cgal_pkg_state not found.

stla commented 1 year ago

So now I did the following and it seems to work:

library(RcppCGAL); cgal_pkg_stage <- list2env(list(ASK_INSTALL = FALSE, CLEANED = FALSE, OLD_VERSION = NA_character_, VERSION = NA_character_, WARNED = FALSE)); cgal_install(version = '5.5.2')
ericdunipace commented 1 year ago

Hi,

It’s due to the release of the 5.6 beta which my function wasn’t able to parse correctly for the download file. I’m testing a version which should handle the beta’s correctly (i.e., download only the last stable release). Should be up later today on GitHub and hopefully on CRAN soon.

Eric On Jun 17, 2023, 9:06 AM -0700, stla @.***>, wrote:

So now I did the following and it seems to work: library(RcppCGAL); cgal_pkg_stage <- list2env(list(ASK_INSTALL = FALSE, CLEANED = FALSE, OLD_VERSION = NAcharacter, VERSION = NAcharacter, WARNED = FALSE)); cgal_install(version = '5.5.2') — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ericdunipace commented 1 year ago

The current version on the GitHub here should work. Issue #9 should fix this and is submitted to CRAN. Thanks for flagging!

ericdunipace commented 1 year ago

@stla New version on CRAN now and the Github is further updated with some minor wording changes to readme that hopefully makes things more clear in general. Please let me know if you find further bugs!