search

ericdunipace / RcppCGAL

Package to link to CGAL (Computational Geometry Algorithms Library) header files. Downloads CGAL version 5.6.1 on install.
10 stars 3 forks source link

What has changed in version 5.6.3? (my package no longer works) #18

Closed stla closed 2 months ago

stla commented 4 months ago

Hello Eric,

Since version 5.6.3, the compilation of my package cgalPolygons throws a myriad of errors: R CMD checks.

You can see that the check is ok on Windows, but the installation on Windows has downloaded version 5.6.2.

I'm not familiar with the compilation reports of C++ code but I'm under the impression the reports find some errors not in my code but in the CGAL code, that's very strange.

ericdunipace commented 4 months ago

Can you try using the 5.6.1 headers from the CGAL release and see if that fixes your problem. I tried to correct another users UBSAN issue, which may be the cause, but you should test your package with the CGAL release first to see if that's the issue.

stla commented 4 months ago

Hi,

Ok I will try later.

I also got UBSAN issues with this package. I reported to the CGAL team and they told me these issues have been fixed.

ericdunipace commented 4 months ago

The issues are fixed in 6.0, which should be released soon; unfortunately, when I tried building my package with the master version of the CGAL headers, it caused errors in a few of the CRAN packages. Please keep me updated.

ericdunipace commented 4 months ago

If using the 5.6.1 version of the header files, fixes your issue, I can push a new version of the CGAL headers without my hacky UBSAN fix, probably in early June so as not to upset the CRAN mainteners. Let me know

stla commented 3 months ago

Hello Eric,

I've tried with CGAL 5.6.1 and the R CMD checks have been successful.

ericdunipace commented 2 months ago

Pushed a version to CRAN (5.6.4) that should fix this; I will be testing the 6.0 beta soon to see if there are any breaking changes.