search

ericdunipace / RcppCGAL

Package to link to CGAL (Computational Geometry Algorithms Library) header files. Downloads CGAL version 5.6.1 on install.
10 stars 3 forks source link

Current version of CGAL on CRAN has missing member functions, leading to potential package removal #19

Open tylermorganwall opened 2 months ago

tylermorganwall commented 2 months ago

See the following issue I filed in the CGAL repo for details:

https://github.com/CGAL/cgal/issues/8313

And the failing CRAN logs here:

https://www.stats.ox.ac.uk/pub/bdr/clang19/raybevel.log

ericdunipace commented 2 months ago

I reverted to the base version of the CGAL headers (5.6.1) rather than my previous hacky fix for the previous UBSAN issue given another user was having problems with their development version. On reverse dependency checks, raybevel passed with the new version and failed to install with the old. Apologies. This should hopefully be resolved.

tylermorganwall commented 2 months ago

This is actually a separate issue than the previous UBSAN problem: raybevel currently isn't yet being taken down due to this CGAL header issue, but BDR warned package developers that encountered this issue on llvm/clang19 that the countdown would begin once clang 19 was released.

Note that I have submitted a pull request (https://github.com/CGAL/cgal/pull/8330) to CGAL that fixes the issue and has been approved and is just waiting to be merged. All you'll have to do (once the PR has been merged) to resolve this is update RcppCGAL's headers to the latest version.

ericdunipace commented 1 month ago

Sorry for the misunderstanding! Re-opening this for now.

I will also say CRAN has strongly objected (removed my package) when I didn't download a fixed version of the CGAL header files. Hence, I'll likely have to wait till the PR makes it into a formal CGAL release.

tylermorganwall commented 1 month ago

The pull request has been merged into the 5.6.x-branch:

https://github.com/CGAL/cgal/pull/8330