search

ericelliott / credential

Easy password hashing and verification in Node. Protects against brute force, rainbow tables, and timing attacks.
MIT License
348 stars 28 forks source link

remove extra buffer creation #54

Closed mvayngrib closed 8 years ago

mvayngrib commented 8 years ago

thanks for the library!

if this is a mistake and you know of a case where it's needed, let's add a breaking test

mastilver commented 8 years ago

string.toString doesn't handle encoding

Check: http://devdocs.io/javascript/global_objects/string/tostring

mvayngrib commented 8 years ago

@mastilver right, but as far as I understand, node's hashing functions all return buffers.

mastilver commented 8 years ago

@mvayngrib you are right... my bad (red your PR to quickly) lgtm then ;)