Update deps, freshen code, release new major version.

ericelliott / credential

Easy password hashing and verification in Node. Protects against brute force, rainbow tables, and timing attacks.

MIT License

347 stars 28 forks source link

Update deps, freshen code, release new major version. #82

Open ericelliott opened 6 years ago

labsvisual commented 6 years ago

I would like to help!

tjconcept commented 6 years ago

I had a bunch of stuff laying around in branches, so I brought a version up to date here: https://github.com/srcagency/credentials

The code base is pretty much a complete rewrite though :P

ericelliott commented 6 years ago

@tjconcept Complete rewrite is fine, as long as the tests still pass and the objectives are still met. Looks like the issues I had with your changes have been fixed. I'm open to merging your changes here.

tjconcept commented 6 years ago

as long as the tests still pass

They don't. The interface is different:

By default there's no instantiation or even a constructor/closure
The configure function returns new bound versions of all functions (factory)
Promises, no CBs
Requires a much newer Node.js version

ericelliott commented 6 years ago

I assume you've updated the test suite and that all the new tests pass? If so, we could simply push it as a new major version.

We'd need to update the docs and run another security review, but I think it's fine.

tjconcept commented 6 years ago

I assume you've updated the test suite and that all the new tests pass?

Oh, yes, of course 😛

Feel free to do that.

ChrisRus commented 5 years ago

Just looking at this. Is the intent that if/when this is released it will be a breaking API change? Thanks.