search

ericelliott / h5Validate

An HTML5 form validation plugin for jQuery. Works on all major browsers, both new and old. Implements inline, realtime validation best practices (based on surveys and usability studies). Developed for production use in e-commerce. Currently in production with millions of users.
576 stars 125 forks source link

errorClass different element #15

Closed IschaGast closed 12 years ago

IschaGast commented 13 years ago

Sometimes you want to add an errorClass to an element that's around your label and inputs. This way you can change the color from your labels etc...

That would be a nice feature.

ericelliott commented 13 years ago

Thanks for the suggestion. It's certainly a good one. In the mean time, you can override the markValid and markInvalid functions, but be aware, I'm planning to change the function signatures in the next version.

jan-harmsen commented 13 years ago

+1 regarding errorClass for different element. I am currently evaluating various html5 form libs and just stumbled on h5Validate which looks quite good on first impression. What does concern me is your remark about changing the API (function signatures) in the next version, since this breaks backwards compatibility. What is the general strategy towards providing backwards compatibility in future versions of h5Validate? Thanks!

ericelliott commented 13 years ago

I think what I'll do is offer callbacks that you can pass in for markValid and markInvalid so that you can do whatever you need to do to customize your implementation, and still take advantage of all the testing and best practices that we've baked into h5Validate.

FYI, the function signatures have already been updated - replaced the parameters with an options collection so that we can make non-breaking changes if we need to modify options in the future.

I don't anticipate any more breaking changes. The roadmap for 1.0 is to let users pass in their custom callbacks during initialization, so that won't require any incompatible changes to the API.

jan-harmsen commented 13 years ago

THANKS for responding that fast and with such good news, sounds great, that's exactly what I had hoped for :-)

ericelliott commented 13 years ago

In case you're curious -- those callbacks have been pushed as of 0.6.0 -- but I haven't written any documentation for them. You can pass in callbacks for both markValid and markInvalid methods, and there's some other new hotness as well: $('#myField').h5Validate('isValid') will return true or false, as will $('myForm').h5Validate('allValid); -- but there is a chance that I'll change the function signatures on those before the 1.0 release.

tmikaeld commented 12 years ago

Please let us know if you change those, as i'm currently using them extensively.

ericelliott commented 12 years ago

isValid changed today. You might want to look at the diff from the last pull.