search

ericelliott / h5Validate

An HTML5 form validation plugin for jQuery. Works on all major browsers, both new and old. Implements inline, realtime validation best practices (based on surveys and usability studies). Developed for production use in e-commerce. Currently in production with millions of users.
576 stars 125 forks source link

added min and max validation [Fixes #90] #91

Open gruberb opened 10 years ago

gruberb commented 10 years ago

fixed the comments

ericelliott commented 10 years ago

Do we have unit tests for this?

ericelliott commented 10 years ago

[#90]

christianlent commented 10 years ago

As soon as this pull request has unit tests, I would be more than happy to refactor this into the unified validator model from https://github.com/ericelliott/h5Validate/pull/87 . It would make it a bit cleaner (the min/max logic would be a little more contained). I definitely love the idea of h5Validate having this capability.

ericelliott commented 9 years ago

Any progress on this, guys?

christianlent commented 9 years ago

I really haven't looked at this since my last comment, but I'm confident that it would fit nicely into the new validator model in #87 . As soon as you've dealt with unified validators one way or another, I can look into this (including perhaps adding some unit tests?).

ericelliott commented 9 years ago

Honestly, I'm so buried in my current work, it may be a very long time before I have time to deal with it. Would you be interested in becoming the official maintainer of h5Validate?

Ideally, every commit will still go through the PR process, and somebody else should at least have the chance to pull down the PR, run the unit tests, and look at the code changes.

christianlent commented 9 years ago

Perhaps, or at least maybe just pick up the slack for as long as you're over-committed.

ericelliott commented 9 years ago

@christianclent Would you be interested in leading a rewrite project?