search

ericf / express-handlebars

A Handlebars view engine for Express which doesn't suck.
BSD 3-Clause "New" or "Revised" License
2.31k stars 382 forks source link

Set compilerOptions to undefined by default #127

Closed Ramonacus closed 9 years ago

Ramonacus commented 9 years ago

As handlebars.js is checking options against "undefined" and then doing an "in" operator, this is throwing an error when using the defaults.

ericf commented 9 years ago

This relates to #125.

Do you have a reference to the Handlebars change that caused this? I would prefer the fix to happen in Handlebars and not here as null is the value I want here since it's the missing object value.

ericf commented 9 years ago

See: https://github.com/wycats/handlebars.js/commit/4bed826d0e210c336fb9e500835b1c1926562da5

Ramonacus commented 9 years ago

I understand your point of view. I'll go poke them to see if they make a wiser check :)