ericf / express-handlebars

A Handlebars view engine for Express which doesn't suck.
BSD 3-Clause "New" or "Revised" License
2.31k stars 384 forks source link

Possible documentation issue regarding NODE_ENV #202

Open brentpayton opened 7 years ago

brentpayton commented 7 years ago

Should the line

process.env.NODE_ENV === "dev";

be

process.env.NODE_ENV = "dev";

?

pietrofxq commented 7 years ago

No. You should not assign NODE_ENV in your code, this value comes from the system path variables. The documention is explaining something that happens only in dev mode, OR: process.env.NODE_ENV === "development"