ericf / express-handlebars

A Handlebars view engine for Express which doesn't suck.
BSD 3-Clause "New" or "Revised" License
2.31k stars 384 forks source link

Rewrite with Promises #68

Closed ericf closed 10 years ago

ericf commented 10 years ago

Getting this package finally ready for v1.0, I've decided to rewrite it using Promises instead of using callbacks and the async lib. This reduce both the SLOC and complexity of this code, while also creating an easier to use API that's more composable with other async tasks.

Changes

The refactoring changes above have lead to some pre-v1.0 API breakage, both in terms of method names and return values. I'm favoring a clean, breaking removal over deprecating APIs; please comment if you feel sternly otherwise.