search

ericf / express-handlebars

A Handlebars view engine for Express which doesn't suck.
BSD 3-Clause "New" or "Revised" License
2.31k stars 384 forks source link

Doesn't work in 0.8, because setImmediate is not defined #78

Closed mixu closed 10 years ago

mixu commented 10 years ago

The package.json engines field in the repo suggests it works with Node 0.8, but https://github.com/ericf/express-handlebars/blob/master/lib/utils.js uses setImmediate. setImmediate was introduced in Node 0.10.x e.g. https://github.com/joyent/node/wiki/Api-changes-between-v0.8-and-v0.10#added

This manifests as a hang when rendering on node 0.8.x + Express 3.x.

ericf commented 10 years ago

Thanks for reporting this. I will update it to correct the engines entry in the package.json to be >=0.10.

ericf commented 10 years ago

Published in v1.0.2.