ericferon / glpi-archisw

GLPI plugin for application inventory
GNU General Public License v2.0
8 stars 5 forks source link

Failed to create new app #64

Closed karokarov closed 1 year ago

karokarov commented 1 year ago

After some manipulation with custom attributes (see issue #63) GLPI refuses to create new apps. Pressing Add button does nothing, new application is not saved.

I have tried to move the 'suspicious' fields (Owning department and Business owner) to trashbin but it did not help.

In debug mode it shows mutiple errors: "PHP Notice (8): Undefined index: plugin_dataflows_configdfhaligns_id in /srv/www/htdocs/plugins/archisw/inc/swcomponent.class.php at line 714"

I also have noticed, that when opening the form it does not automatically calculate 'level'.

Please advice.

karokarov commented 1 year ago

I have found the root cause. The problem was in the new fields of Integer type, which were considered by the system as mandatory. I found the following record in glpi sql error log file: "Error: Incorrect integer value: '' for columnglpi.glpi_plugin_archisw_swcomponents.icbc_process_criticalityat row 1"

So now, I have made a statecheck rule for these attributes and the problem with validation seems to be gone. image

Btw, any idea how to make these business impact attributes more user friendly? Specificly:

And thank you once more for the wonderful and powerful plugins!

ericferon commented 1 year ago

Hi, There was indeed a bug, fixed in v3.0.7. Concerning the userfriendliness, the proposed fields display are the standard ones, from the GLPI core team. With statecheck rules, you can indeed control the values, but not the display. I could examine later whether I can enhance the display without requesting too much parameters to define a field. K.r,