search

ericgio / weekday-golf

A codified history of our bi-weekly-ish games.
1 stars 2 forks source link

Add support for different courses #13

Open makinde opened 3 years ago

makinde commented 3 years ago

This way we can add the round that happened with Gio, Makinde, and Jess. This is probably a pretty extensive undertaking since it requires us to support different par scores and other things that are hard coded.

ericgio commented 3 years ago

I assume this change would also make the per-hole stats obsolete right? Doesn't make sense to compare hole averages across courses.

makinde commented 3 years ago

My idea here was that replace “stats” with “course stats” in the top nav. Could be a drop down menu showing you the first 5 (which would be all for the foreseeable future) course. Clicking on the “course stats” nav item takes you to the first option in the list. List is sorted by number of rounds played. So essentially each course getting a page for stats at that course, and default to the Mariners point page.

If we do #14, we could have a drop down or something there to select which course to show stats for if there are graphs and stuff.

It’s be a pretty big change, and a lot of code, for what is 1 extra round! So it might make sense to punt. That said, we can’t easily play other courses until the site supports it. Catch 22.

makinde commented 3 years ago

Would might also need to track different parts for holes, and maybe need to start showing scores as -/e/+ relative to par to make it more understandable on a course like the one we played with Jess.

ericgio commented 3 years ago

I'd say this is pretty low-pri. Seems likely that we will only play at Mariner's Point between now and whenever you guys move next summer.