search

ericgjackson / slumbot2019

Implementations of CFR for solving a variety of Holdem-like poker games
MIT License
133 stars 31 forks source link

MCCFR example #13

Open xgshark opened 4 years ago

xgshark commented 4 years ago

When I follow the instructions in the readme for the MCCFR example I get an error when running the last command:

../bin/run_tcfr holdem_params nhs2_params mb1b1_params ecfr_params 8 1 2 100000000 1 -> "Unknown algorithm: ecfr "

Looking at run_tcfr.cpp this looks like the intended response and run_tcfr is not supposed to be run with ecfr_params? When I change it to: ../bin/run_tcfr holdem_params nhs2_params mb1b1_params tcfr_params 8 1 2 100000000 1

I get the error message saying that /data/cfr//holdem.2.nhs2.13.4.3.mb1b1.tcfr/regrets.x.0.0.0.0.p0.i can not be opened(directory does not exists indeed). All the preparing commands went through without any error. The CFR+ example got me an appropriate directory. What am I missing?

Thanks for any help.

bluedevils23 commented 3 years ago

Same issue

ericgjackson commented 3 years ago

Sorry for late response.

I've changed the code to read and write from the current directory (by default). If you want to specify a different path, do so in src/files.cpp and make sure the directories you provide there exist.

I've also fixed the tcfr/ecfr confusion in the README.