ericgjackson / slumbot2019

Implementations of CFR for solving a variety of Holdem-like poker games
MIT License
133 stars 31 forks source link

mp_betting_tree CreateMPStreet error #33

Closed ZHANGTIANHE closed 1 year ago

ZHANGTIANHE commented 1 year ago

Hello, Is it a bug in mp_betting_tree.cpp line 429 i check when calling CreateMPStreet, street will add 1 outside, so is it unnessasary to add 1 again? i think the right code is below int next_player_to_act = NextPlayerToAct(Game::FirstToAct(street), folded) while old code is int next_player_to_act =NextPlayerToAct(Game::FirstToAct(street + 1), folded);

ericgjackson commented 1 year ago

Yes, your change looks correct. I will fix. Thanks.

ZHANGTIANHE commented 1 year ago

Thanks for the awesome project