search

ericgjackson / slumbot2019

Implementations of CFR for solving a variety of Holdem-like poker games
MIT License
133 stars 31 forks source link

subgame solving #6

Closed Kailianghu closed 5 years ago

Kailianghu commented 5 years ago

Hi, @ericgjackson Thanks for your open source, you are doing an amazing job! In slumbot2019/src/#solve_one_subgame_unsafe.cpp# line 478-481 I notice you have already implemented the unsafe, CFR-D, MaxMargin subgame solving, what is the combined means? I have noticed it is not Noam reach subgame solving, do you have the plan to implement it?

ericgjackson commented 5 years ago

I think the MaxMargin resolving is not tested; I wouldn't rely on it

I don't have any time right now to implement Noam's method of resolving.

The combined method is something I came up with. It's sort of a blend of unsafe resolving and CFR-D. It's the best performing method for me.

On Mon, Jul 29, 2019 at 8:46 PM kailiang.hu notifications@github.com wrote:

Hi, @ericgjackson https://github.com/ericgjackson Thanks for your open source, you are doing an amazing job! In slumbot2019/src/#solve_one_subgame_unsafe.cpp# line 478-481 I notice you have already implemented the unsafe, CFR-D, MaxMargin subgame solving, what is the combined means? I have noticed it is not Noam reach subgame solving, do you have the plan to implement it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ericgjackson/slumbot2019/issues/6?email_source=notifications&email_token=ABUMRNJWCR4JHJDDS75AVNDQB62QFA5CNFSM4IHYDI32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCGDFBQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUMRNKTSTQIO7OYQXS2RQDQB62QFANCNFSM4IHYDI3Q .