search

ericgoolsby / Rphylopars

Phylogenetic Comparative Tools for Missing Data and Within-Species Variation
28 stars 11 forks source link

Switch to arma_cerr_stream<T> #55

Open eddelbuettel opened 1 year ago

eddelbuettel commented 1 year ago

Armadillo updates its coding convention over time. We have been fairly hard at work to have RcppArmadillo-using packages switch from a now-deprecated older way of instantiatig variables to a newer one (see issue #391 for details; this PR is part of the related issue #402).

When compiling packages using RcppArmadillo with the deprecation-warning-suppressor we still use, some new warnings come up. One concerns a deprecated way of setting an output or error stream as your package does in three spots in one file. Changing this is fairly straightforward, and affects only that one file.

The package passes its tests with the change as it did before.

It would be much appreciated if you could apply this pull request and update the package at CRAN within the next few months. Let me know if you have any questions.

conradsnicta commented 1 year ago

@ericgoolsby A better solution is to simply remove all use of arma::set_cerr_stream(). No replacement code should be necessary.

Armadillo by default prints far fewer warnings since version 10.4, so use of arma::set_cerr_stream() is not required.

More details at: https://github.com/RcppCore/RcppArmadillo/issues/402#issuecomment-1384816643