search

ericgrandt / TotalEconomy

All in one economy plugin for Minecraft.
https://ericgrandt.github.io/TotalEconomy/
31 stars 33 forks source link

Console error Could not pass DestructEntityEvent$Death$Impl #322

Closed infamyreloaded closed 5 years ago

infamyreloaded commented 5 years ago

Minecraft: 1.12.2 SpongeAPI: 7.1.0-70763aa8 Sponge: 1.12.2-7.1.4 SpongeForge: 1.12.2-2768-7.1.4 Minecraft Forge: 14.23.5.2768 Total Economy Version: 1.8.1

Description of issue

Totaleconomy gives me an error in console. I'm not sure when it happens but it looks like when a player kills a mob. I have jobs disabled also in case that matters.

Console errors

https://hastebin.com/kesomuziba.rb

MarkL4YG commented 5 years ago

Hey there, thank you for submitting this issue.
According to the information from the logs, the EntityDamageSource seems not to contain the actual source representation (which should be the player in this case) throwing an exception in this line.
We can work-around by including an additional null-check in the code. However, that value being null conflicts with the interface contract as it is not an Optional value. There might be something going wrong deeper in Sponge if you ask me.

Can you provide more information on your ingame setup?

@Erigitic what do you think?

infamyreloaded commented 5 years ago

I'm not sure what weapon it is, but I'll keep an eye out. I'll check this weekend and see if I can find what item and mob causes it. It probably has something to do with techguns because that mod has so many error.

infamyreloaded commented 5 years ago

Just giving an update, haven't forgot about it. Still trying to find the cause.

infamyreloaded commented 5 years ago

So I did 2 things and haven't seen the error since then. I'm not sure which was the cause, but I updated my forge version and updated my techguns version and I haven't seen the error pop up again. I'm thinking it was one of the the guns in techguns but not sure. If I ever see it again I'll try to find it and post it here but you can close this for now.

MarkL4YG commented 5 years ago

Alright, let's hope there's not going to be a reason for you to get back to this ;)
It is possible that the Forge and/or Techguns update fixed a bug that was causing this issue imo.

infamyreloaded commented 5 years ago

That's most likely the case. There were some other problems I was having before updating and those are gone now.