search

ericgrandt / TotalEconomy

All in one economy plugin for Minecraft.
https://ericgrandt.github.io/TotalEconomy/
MIT License
32 stars 33 forks source link

Help with sub ids of certain blocks #336

Closed kamrantekkit closed 5 years ago

kamrantekkit commented 5 years ago

i am creating config file for the lumberjack job but i ran into a problem on a modpack server. there is mod that add more wood types but they all have the same sub id.

MarkL4YG commented 5 years ago

Try breaking a block of that type with /job toggle block-break-info enabled.

kamrantekkit commented 5 years ago

command doesnt exist

MarkL4YG commented 5 years ago

When "/job" does not exist, you can have 2 issues:

  1. TotalEconomy is not installed
  2. Your configuration has a syntax error. In that case, please check your server log and/or attach your configuration files in a gist
kamrantekkit commented 5 years ago

got the command working }
"extratrees:logs.9":{ id-trait="variant"
type { EUCALYPTUS2 { exp="10" money="1.00" } EUCALYPTUS3 { exp="10" money="1.00" } CHERRY { exp="10" money="1.00" } CINNAMON { exp="10" money="1.00" this what i did but it didnt work. any ideas? all these wood types use the same sub id "logwood"

MarkL4YG commented 5 years ago

If you use "variant" as the id trait. You will also need to use "variant" as the key for the different types (As can be seen here)

...
"extratrees:logs.9":{
    id-trait="variant"
    variant {
      EUCALYPTUS2 {
        exp="10"
        money="1.00"
      }
      EUCALYPTUS3 {
         exp="10"
        money="1.00"
      }
      CHERRY {
        exp="10"
        money="1.00"
      }
     ...

Should be, what you're aiming for.

kamrantekkit commented 5 years ago

thx

MarkL4YG commented 5 years ago

I guess that means, this worked? 👀

kamrantekkit commented 5 years ago

havent tried it yet. waiting on the server owner

kamrantekkit commented 5 years ago

}
"extratrees:logs.9":{ id-trait="variant"
variant { EUCALYPTUS2 { exp="10" money="1.00" } EUCALYPTUS3 { exp="10" money="1.00" } CHERRY { exp="10" money="1.00" } CINNAMON { exp="10" money="1.00"
} i tried but it didnt work

MarkL4YG commented 5 years ago

The mod you're trying to use is "extra trees"?
I am going to test this mod out tomorrow or on Saturday and see if there's some unexpected bug going on.

kamrantekkit commented 5 years ago

yes Binnie's extra trees

kamrantekkit commented 5 years ago

also doesnt work with twilight forest trees } "twilightforest:twilight_log":{ id-trait="variant" variant { OAK { exp="10" money="1.00" } CANOPY { exp="10" money="1.00" } MANGROVE { exp="10" money="1.00" } DARKWOOD { exp="10" money="1.00" }

MarkL4YG commented 5 years ago

Since I did not find any trees from binnies mods, I went to try this with the bushes which have their leaves traited in the same way the trees do.
I was certainly able to get this to work as intended:
Reward for "Raspberry" leaves:
image

No reward for others: image

Job set example: 

    lumberjackSet {
        break {
            "extratrees:leaves.default.19" {
                "id-trait"="variant"
                "variant" {
                    "Raspberry" {
                        "exp"="100000"
                        "money"="20"
                    }
                }
            }
        }
    }

This should work exactly the same way for the trees.
If it does not work, I would like to know more about your setup and the way you're trying to get this working.

kamrantekkit commented 5 years ago

https://gist.github.com/kamrantekkit/40c2d0b4a3eed280f5b32cc5a29ca968 https://gist.github.com/kamrantekkit/cb798b9749695b0e11ab3e814bba4761 top is the sets bottom is the jobs sponge version: 1.12.2-2768-7.1.6-snapshot binnie version:1.12.2-2.5.1.188

kamrantekkit commented 5 years ago

any idea?

MarkL4YG commented 5 years ago

Not directly. But I have tested your sets with binnies mods and twilight forest and it appears that some of the actions do not end up in the internal job set.
I will have to verify this in a development environment so I can see what actually goes on.
Might have time today or tomorrow.

kamrantekkit commented 5 years ago

found what could be the problem?

MarkL4YG commented 5 years ago

Sorry, I was busy preparing some services for "Blackout21".

I have now tried to reproduce this in a development environment.
Sadly, this did not only not yield any direct result, in addition things are working just normal in the development workspace:
image I will check for a possible cause of this.

MarkL4YG commented 5 years ago

I have now tried to reproduce this on both the develop branch and my latest action-refactor branch.
Both appear to correctly handle your job sets.

kamrantekkit commented 5 years ago

ok let me know what can be the problem

MarkL4YG commented 5 years ago

Can you try building the plugin from source to test this with the latest development build?

kamrantekkit commented 5 years ago

what you mean?

MarkL4YG commented 5 years ago

The current release is 1.8.1. I would like you to test a development build for version 1.8.2 so we can see if the issue is still there in the latest development version.

kamrantekkit commented 5 years ago

i cant change the plugin version in server. thx anyway for your help. you dont need to help me anymore.

MarkL4YG commented 5 years ago

It's not like I wouldn't like to know what's going wrong on your side.
It's just difficult to reproduce.

kamrantekkit commented 5 years ago

the server owner on the server i am staff on is making custom plugin so yeah.

MarkL4YG commented 5 years ago

If they really require to do so. They could also try finding the issue and submit a fix to TE in case this really is a bug.

MarkL4YG commented 5 years ago

@kamrantekkit is your issue resolved or you do not want to investigate further? If it is resolved or further investigation is not possible, I think we can close the issue.
If anyone happens to run into a similar issue, they should open a new issue anyways.

kamrantekkit commented 5 years ago

i don't want it to be investigated any further.